Should that not be a part of the plugin release? This is a vote for the platform release - does the fix impact the platform too ?
-----Original Message----- From: Maxime LUCE [mailto:[email protected]] Sent: Thursday, October 2, 2014 3:34 AM To: [email protected] Subject: RE: [VOTE] 3.6.4 Windows Release - There is a bug fix for big file write on Windows 8 and Windows platforms in cordova-plugin-file ! It could be a good idea to review and merge this fix ! Cordialement. Maxime LUCE Touchify, CEO +33 6 28 60 72 34 | skype: maximeluce [email protected] | http://touchify.co -----Message d'origine----- De : Parashuram Narasimhan (MS OPEN TECH) [mailto:[email protected]] Envoyé : mercredi 1 octobre 2014 19:47 À : [email protected] Objet : RE: [VOTE] 3.6.4 Windows Release Sorry, I meant leaving it as is works. Since this will be published in the blog post, we don't have to restart the vote. -----Original Message----- From: Steven Gill [mailto:[email protected]] Sent: Wednesday, October 1, 2014 10:20 AM To: [email protected] Subject: Re: [VOTE] 3.6.4 Windows Release So you want me to move releasenotes in 3.6.x branch and restart the votes? Just clarifying On Wed, Oct 1, 2014 at 10:13 AM, Parashuram Narasimhan (MS OPEN TECH) < [email protected]> wrote: > I think moving RELEASENotes works good. +1 on the vote. > > -----Original Message----- > From: Steven Gill [mailto:[email protected]] > Sent: Wednesday, October 1, 2014 10:06 AM > To: [email protected] > Subject: Re: [VOTE] 3.6.4 Windows Release > > Windows and WP8 will be missing release notes because we are using npm > pack to package and the packaged directory is a subdirectory in the repo. > RELEASENOTES.md is in the root. > > This is the last release where the package directory is a sub directory. > Master for both those repos have moved all files to the root > (including package.json). Future releases will include RELEASENOTES.md. > > We could move RELEASENOTES.md into the sub directory on the 3.6.x > branch for both repos and retag. I don't think it is necessary since > the notes will be posted in the blog post, but if people feel strongly > about including it, I will go ahead and do it. > > > > On Wed, Oct 1, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) < > [email protected]> wrote: > > > I vote +1 > > * Checked package files - there is missing RELEASENOTES.md file > > * Ran coho verify-archive over the relevant repo > > * Verified ability to create and run Cordova app with windows > > platform > > * Tested building and running app with --phone, --win, --archs > flags > > (successfully build and run) > > * Validated created apps via Cert Kit > > * Verified supporting of --target key > > * Run medic tests > > > > Missing RELEASENOTES file is not a critical bag, so I still vote +1. > > > > Thx! > > Sergey > > > > -----Original Message----- > > From: Steven Gill [mailto:[email protected]] > > Sent: Wednesday, October 1, 2014 2:05 AM > > To: [email protected] > > Subject: [VOTE] 3.6.4 Windows Release > > > > Please review and vote on this 3.6.4 Windows Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-7661 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-7661 > > > > The package was published from its corresponding git tag: > > cordova-windows: 3.6.4 (b940eca6fe) > > > > Upon a successful vote I will upload the archive to dist/, publish > > it to NPM, and post the corresponding blog post. > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti > > ng .md Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Used `license-checker` to ensure all dependencies have > > Apache-compatible licenses > > >
