GitHub user mysegfault opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/71
hack: very bad fix but just works for fixing the dialog closing on Andro...
On Android, it's very frequent to fall into this bug : you cannot close the
inappbrowser dialog when you click on the X button. The impact is massive
because the user get stuck and cannot even go back to the app, so you can only
kill the app...
I'm not so familiar with this code but I just can understand that there are
multiple dialogs (new InAppBrowserDialog) that are created when only opening
one URL => happens when there are many redirections when launching the first
URL (ex: twitter.com). So when you click on the close button, the code only
close the latest created dialog (via dialog.dismiss()) but not all of them.
That is why I added a very simple test that dismiss the previous dialog
when you want to create new one.
This is not a clean fix but it just works. Please review and comment this
pull request, because as I said before, the impact is huge for the users.
Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mysegfault/cordova-plugin-inappbrowser
android-cannot-close-dialog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit abe9963f5e1c457cd925345a1130d1849dbd07e4
Author: Maxime <[email protected]>
Date: 2014-12-05T11:11:39Z
hack: very bad fix but just works for fixing the dialog closing on Android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
