The vote has now closed. The results are: Positive Binding Votes: 3 Andrew Grieve Maxim Ermilov Steven Gill
Negative Binding Votes: 0 The vote has passed. I will publish to dist + npm later today. Thx! On Wed, Dec 24, 2014 at 12:44 PM, Sergey Grebnov (Akvelon) < [email protected]> wrote: > When I build default app template I see the following error (no such > problem w/ 3.6.3): > > Missing icon > Command finished with error code 1: > > Adding <icon src="img/icon.png" /> to config.xml fixes the problem > > Looks like this is due to the following logic: > https://github.com/apache/cordova-ubuntu/blob/master/bin/templates/project/cordova/lib/manifest.js#L46 > > Detailed trace: > > sg@acer:~/app$ cordova platforms > Installed platforms: ubuntu 4.0.0 > .. > sg@acer:~/app$ sudo cordova build ubuntu -d > missing icon element in config.xml > missing icon element in config.xml > Generating config.xml from defaults for platform "ubuntu" > Calling plugman.prepare for platform "ubuntu" > Preparing ubuntu project > Processing configuration changes for plugins. > Iterating over installed plugins: [] > Writing out cordova_plugins.js... > missing icon element in config.xml > Running command: /home/sg/app/platforms/ubuntu/cordova/build > Building Desktop Application... > Missing icon > Command finished with error code 1: > /home/sg/app/platforms/ubuntu/cordova/build > Error: /home/sg/app/platforms/ubuntu/cordova/build: Command failed with > exit code 1 > at ChildProcess.whenDone > (/usr/share/cordova-cli/node_modules/cordova-lib/src/cordova/superspawn.js:135:23) > at ChildProcess.EventEmitter.emit (events.js:98:17) > at maybeClose (child_process.js:743:16) > at Process.ChildProcess._handle.onexit (child_process.js:810:5) > > Thx! > -Sergey > -----Original Message----- > From: Steven Gill [mailto:[email protected]] > Sent: Tuesday, December 23, 2014 9:22 PM > To: [email protected] > Subject: Re: [Vote] 4.0.0 Ubuntu Release > > +1 > > Verified archive > On Dec 23, 2014 8:01 AM, "Andrew Grieve" <[email protected]> wrote: > > > +1 > > > > * coho verify-archive worked fine for me. > > * Verified sha1s match tags with `coho verify-tags` > > * Verified archive contents via extracting & diff -r > > > > Only thing I saw at all awry is that RELEASENOTES.md has an entry for > > 4.0.0 in the tgz, but not in master within the repo (forgot to > > commit?) > > > > On Mon, Dec 22, 2014 at 6:02 PM, Maxim Ermilov < > > [email protected]> > > wrote: > > > > > > > The coho verify script is still failing for me. I'll have to spend > > > > some time with it to see what the problem is. > > > > > > I just test "coho verify-archive" in clean container. It works. > > > Did you refresh pgp keys ? > > > > > > -Maxim > > > > > > On Mon, Dec 22, 2014 at 9:26 AM, Steven Gill > > > <[email protected]> > > > wrote: > > > > > > > Sorry Maxim. The coho verify script is still failing for me. I'll > > > > have > > to > > > > spend some time with it to see what the problem is. > > > > On Dec 21, 2014 7:08 AM, "Maxim Ermilov" > > > > <[email protected]> > > > > wrote: > > > > > > > > > > Once this is done > > > > > > > > > > done. > > > > > > > > > > -Maxim > > > > > > > > > > On Fri, Dec 19, 2014 at 10:43 PM, Steven Gill < > > [email protected]> > > > > > wrote: > > > > > > > > > > > We need you to add your gpg key to dist/keys. Checkout the > > > > > > publish > > to > > > > > > dist/keys step at > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg > > .md#creating-a-pgp-key-for-releases > > > > > > > > > > > > Once this is done, I can verify the archive was made by you > > > > > > and > > give > > > > the > > > > > +1 > > > > > > > > > > > > Sorry for all the hoops (the apache way) > > > > > > > > > > > > -Steve > > > > > > > > > > > > On Thu, Dec 18, 2014 at 6:34 AM, Maxim Ermilov < > > > > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > > Please review and vote on this 4.0.0 Ubuntu Release. > > > > > > > > > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-8173 > > > > > > > > > > > > > > Repos ready to be released have been published to dist/dev: > > > > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-8173 > > > > > > > > > > > > > > The package was published from its corresponding git tag: > > > > > > > cordova-ubuntu: 4.0.0 (193fe98aba) > > > > > > > > > > > > > > Upon a successful vote I will upload the archive to dist/, > > publish > > > it > > > > > to > > > > > > > NPM, and post the corresponding blog post. > > > > > > > > > > > > > > Voting guidelines: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > > .md > > > > > > > > > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > > > > > > > > > I vote +1: > > > > > > > * Ran coho audit-license-headers over the relevant repos > > > > > > > * Ran coho check-license to ensure all dependencies and > > > > subdependencies > > > > > > > have Apache-compatible licenses > > > > > > > * Performed manual tests to ensure platform could be > > > > > > > successfully > > > > built > > > > > > and > > > > > > > run > > > > > > > > > > > > > > -Maxim > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
