Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/143#discussion_r22675940
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,7 +207,7 @@ module.exports = function plugin(command, targets,
opts) {
});
}, Q())
.then(function() {
- return
plugman.raw.uninstall.uninstallPlugin(target, path.join(projectRoot,
'plugins'));
+ return
plugman.raw.uninstall.uninstallPlugin(target, path.join(projectRoot,
'plugins')).then(savePluginsToConfig());
--- End diff --
I think here and below you actually want: `.then(savePluginsToConfig)`
rather than `.then(savePluginsToConfig())`. Often with promises, it's best to
just always use `.then(function() {})`, even if all it does is delegate to a
helper.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
