Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24069058
--- Diff: www/medic.js ---
@@ -35,30 +35,27 @@ exports.log = function() {
};
exports.load = function (callback) {
- var xhr = new XMLHttpRequest();
- xhr.open("GET", "../medic.json", true);
- xhr.onload = function() {
- if (xhr.readyState == 4 && (xhr.status == 0 || xhr.status == 200)) {
- var cfg = JSON.parse(xhr.responseText);
- exports.logurl = cfg.couchdb || cfg.logurl;
- exports.enabled = true;
- exports.sha = cfg.sha;
- console.log('Loaded Medic Config: logurl=' + exports.logurl);
- }
- callback();
- }
- xhr.onerror = function() {
- callback();
- }
+ var jsonMedic = null;
try {
+ // attempt to synchronously load medic config
+ var xhr = new XMLHttpRequest();
+ xhr.open("GET", "../medic.json", false);
xhr.send(null);
- }
- catch(ex) {
- // some platforms throw on a file not found
+ jsonMedic = xhr.responseText;
+ } catch (ex) { }
+
+ // config is available
+ if (jsonMedic) {
+ exports.logurl = JSON.parse(jsonMedic).logurl;
--- End diff --
Ops, I'll fix this shortly. Thx @nikhilkh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
