Hey Georgi, I left some comments on your PR. Only big thing is how you populate preferences, otherwise LGTM. My other comments are mostly nits.
Thanks, -Rob From: [email protected] [mailto:[email protected]] On Behalf Of Andrew Grieve Sent: Monday, March 9, 2015 7:25 AM To: Georgi Alexandrov; dev Cc: [email protected] Subject: Re: Pull Request Review Request [apache/cordova-plugin-splashscreen] Thanks Georgi! Bouncing you to the mailing-list though, as I don't do any Windows development. On Mon, Mar 9, 2015 at 8:15 AM, Georgi Alexandrov <[email protected]<mailto:[email protected]>> wrote: Hi Andrew, I saw that you are one of the main contributors in cordova-plugin-splashscreen. I was wondering if it’s possible to check this<https://github.com/apache/cordova-plugin-splashscreen/pull/38> PR when you have some free time. Thanks, Georgi Alexandrov [Telerik] Georgi Alexandrov Software Engineer, Senior, AppBuilder Core m +359 894 707390<tel:%2B359%20894%20707390> e [email protected]<mailto:[email protected]> w www.telerik.com<http://www.telerik.com/>
