GitHub user CJRChang opened a pull request:
https://github.com/apache/cordova-windows/pull/61
Fix for callback invocation with NO_RESULT
Due to the enumeration of cordova.callbackStatus (NO_RESULT = 0 and OK =
1), the logic used for defaulting to cordova.callbackStatus.OK will always
default to cordova.callbackStatus.OK when the callbackStatus is set to
cordova.callbackStatus.NO_RESULT.
This change addresses this issue by first checking if
callbackOptions.status is null and defaulting to cordova.callbackStatus.OK,
otherwise it will accept the callbackOptions.status value provided by the user.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CJRChang/cordova-windows patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 1e4b5330103af18a75dd82772eab3541b6436f19
Author: CJRChang <[email protected]>
Date: 2015-03-12T01:14:38Z
Fix for callback invocation with NO_RESULT
Due to the enumeration of cordova.callbackStatus (NO_RESULT = 0 and OK =
1), the logic used for defaulting to cordova.callbackStatus.OK will always
default to cordova.callbackStatus.OK when the callbackStatus is set to
cordova.callbackStatus.NO_RESULT.
This change addresses this issue by first checking if
callbackOptions.status is null and defaulting to cordova.callbackStatus.OK,
otherwise it will accept the callbackOptions.status value provided by the user.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
