Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27592776
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = function(options) {
var opts = parseOpts(options);
var builder = builders[opts.buildMethod];
- return builder.prepEnv()
+ return builder.prepEnv(opts)
.then(function() {
- return builder.clean(opts.extraArgs);
+ return builder.clean(opts);
}).then(function() {
shell.rm('-rf', path.join(ROOT, 'out'));
+
+ ['debug', 'release'].forEach(function(config) {
+ var propertiesFilePath = path.join(ROOT, config +
SIGNING_PROPERTIES);
+ if(isAutoGenerated(propertiesFilePath)){
+ shell.rm('-f', propertiesFilePath);
--- End diff --
Yes, currently its not wired up to the CLI. We have received feedback that
it should be wired. I agree deleting after every build is the most 'secure' -
though it breaks the android studio IDE interop story. My thinking is a
developer will specify the build.json file with the required parameters and
iterate using a combination of Android studio and CLI.
Some of this is hard to predict, I'm of the opinion that let's get it out
there and drive some usage and listen to feedback.
Let me know if you feel strongly about removing the deletion of these files
from 'clean'. Having this be there 'clean' allows the developer a way to remove
these files and not rely on internals.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
