Do we have a way to check if specific platform supports current CLI/LIB version? AFAIK there is two places, where <engine> tag is supported (project's config.xml and plugin's plugin.xml) but none of them suits to our case. But if I wrong, could you please point me to docs or code where this check exists?
--------------- Best regards, Vladimir -----Original Message----- From: Nikhil Khandelwal [mailto:[email protected]] Sent: Saturday, 16 May, 2015 2:03 To: [email protected] Subject: RE: Breaking changes in cordova-windows@>3.8.2 The next version of cordova-windows will be 4.0.0 as it has Win10 support (which is a significant update) and this breaking change. Agreed, if there is an engine tag that can make this more explicit - it would be perfect. Thanks, Nikhil -----Original Message----- From: Steven Gill [mailto:[email protected]] Sent: Friday, May 15, 2015 11:44 AM To: [email protected] Subject: Re: Breaking changes in cordova-windows@>3.8.2 Can we set the engine tag so windows >3.8.2 (should be major jump to 4.0.0) requires cordova-lib/cli >=5.1.0 (next version of tools should be a minor jump) On Fri, May 15, 2015 at 9:59 AM, Vladimir Kotikov (Akvelon) < [email protected]> wrote: > Hi List, > > I just want to let you know that we have pending PRs that will > introduce braking changes in cordova-windows. > > These changes will move project update logic call from project build > step to cordova-lib prepare step. The reason why we need this is that > currently project update is triggered directly by build script (after > 'after_prepare' > hook being fired) and this makes plugin hooks and other tools working > incorrectly (changes, made by hooks is being overwritten by this > prepare logic). > > To be more precise, the following cases could be broken: > 1. CLI > 5.0 (next version), Windows <= 3.8.2 (current or older) - the > 'prepare' will be called twice (from lib and from platform's build) - > unwanted, since changes that could be made by 'after_prepare' & > 'before_compile' hooks will be overwritten by second 'prepare' call - > but this is how it works now. > 2. CLI <= 5.0 (current or older), Windows > 3.8.2 (next version) - > 'prepare' will never be called, the platform code will never be > updated - the worst case, the build probably will be broken. > > Some links: > JIRA issue: https://issues.apache.org/jira/browse/CB-9025 > cordova-lib: https://github.com/apache/cordova-lib/pull/217 > cordova-windows: https://github.com/apache/cordova-windows/pull/77 > > We're going to merge this soon, so if anyone has a strong opinion > against these changes, please let us know. > > --------------- > Best regards, Vladimir > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
