GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/233
Fix four failing tests on Windows.
Two tests fail on Windows in a non-admin command window because they rely
on creating symlinks. Since creating the symlinks isn't the purpose of the test
but just setup for the test, if that fails and the platform is `win32`, we now
just bail on the test.
Another test failed because a folder unexpectedly exists when run from a
non-admin prompt. I'm not 100% sure why the folder exists, but the test was
bogus... the test actually ends up testing that we throw if `src` does not
exist, which is something that we verify in an earlier test, while the intent
of the test was to verify we throw if `dest` *already* exists. Since it is
`copyNewFile()` that is supposed to throw in that scenario, so I updated the
test to check for that.
Finally, a fourth test failed on Windows (admin or non-admin) because of
different line endings. Changed that to handle either line ending.
Verified all tests now pass on Windows and still pass on OS X.
Note: I don't believe this is the cause of the AppVeyor failures we are
seeing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib tb-fix-win-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit 0b103f16c4d301611a3cfd6fea967effe880f652
Author: Tim Barham <[email protected]>
Date: 2015-06-02T23:22:11Z
Fix four failing tests on Windows.
Two tests fail in a non-admin command window because they rely on creating
symlinks. Since creating the symlinks isn't the purpose of the test but just
setup for the test, if that fails and the platform is win32, we now just bail
on the test.
Another test failed because a folder unexpectedly exists when run from a
non-admin prompt. I'm not 100% sure why the folder exists, but the test was
actually bogus... the test was actually ends up testing that we throw if src
does not exist (something that we verify in an earlier test), while the intent
was to verify we throw if dest *already* exists. It is copyNewFile() that
throws in that scenario, so I updated the test to check for that.
Finally, a fourth test failed on Windows (admin or non-admin) because of
different line endings. Changed that to handle any line ending.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
