Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/91#discussion_r34892373
  
    --- Diff: template/cordova/lib/run.js ---
    @@ -169,20 +135,10 @@ module.exports.help = function () {
         process.exit(0);
     };
     
    -
    -function getWindowsTargetVersion() {
    --- End diff --
    
    This is not required anymore as we rely on build - we run the first build 
target.
    
    var buildTargets = build.getBuildTargets(args.win, args.phone, args.appx);
    
    ..
    +     if (!buildTargets || buildTargets.lenght <= 0) {
    +         return Q.reject('Unable to determine deploy target.');
    +     }
    +
    +     // we deploy the first build target so we use buildTargets[0] to 
determine
    +     // what project type we should deploy
    +     var projectType = projFileToType(buildTargets[0]);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to