do we have a git commit hook in all repos that run npm test-full, and npm test-full includes all tests including the ones for styles
On Tue, Jul 21, 2015 at 2:55 PM Rob Paveza <[email protected]> wrote: > I would be OK with a style warning as long as the warning checks the > contents of the string for a single-quote, in which case it says, "Oh, you > used double quotes so you could author a single quote without an escape > prefix! I won't error you here." > ________________________________________ > From: Murat Sutunc <[email protected]> > Sent: Tuesday, July 21, 2015 11:34 AM > To: [email protected] > Subject: RE: JSHint breaks the build again > > Yeah this rule is more of a style rule and doesn't check for language > correctness. I'm ok with removing it but I'm also wondering if we should > separately have some sort of a style checker (which will not block CI but > give out warnings). > > -----Original Message----- > From: Nikhil Khandelwal [mailto:[email protected]] > Sent: Tuesday, July 21, 2015 11:12 AM > To: [email protected] > Subject: RE: JSHint breaks the build again > > I agree with your disagreement. :) > > +1 to relaxing the condition. > > Thanks, > Nikhil > > > -----Original Message----- > From: Jesse [mailto:[email protected]] > Sent: Monday, July 20, 2015 6:00 PM > To: [email protected] > Subject: JSHint breaks the build again > > I am sick of seeing my commits cause build CI failures because of single > vs double quote use. > Can we relax this condition? I absolutely disagree with this being an > error! > > Cheers, > Jesse > > My team is hiring! > @purplecabbage > risingj.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB� > � [��X��ܚX�K K[XZ[ � ]�][��X��ܚX�P �ܙ ݘK�\ X� K�ܙ�B��܈ Y ] [ۘ[ ��[X[� > � K[XZ[ � ]�Z [ �ܙ ݘK�\ X� K�ܙ�B >
