Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766275
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts) {
}
}
- events.emit('verbose', 'Calling
plugman.install on plugin "' + dir + '" for platform "' + platform + '" with
options "' + JSON.stringify(options) + '"');
- return plugman.raw.install(platform,
platformRoot, path.basename(dir), pluginsDir, options);
+ events.emit('verbose', 'Calling
plugman.install on plugin "' + result.dest + '" for platform "' + platform + '"
with options "' + JSON.stringify(options) + '"');
+ return plugman.raw.install(platform,
platformRoot, path.basename(result.dest), pluginsDir, options);
});
- }, Q());
+ }, Q()).then(function(){
+ return Q(result);
+ });
+ })
+ .then(function(result){
+ metadata.save_fetch_metadata(pluginsDir,
result.pinfo.id, { source: result.fetchJsonSource, variables:
opts.cli_variables, is_top_level: true });
+ return Q(result.dest);
+ })
+ .then(function(dir){
+ // save to config.xml
+ if(saveToConfigXmlOn(config_json,opts)){
--- End diff --
Usage: Function name `saveToConfigXmlOn` implies that it performs the
saving, but your branch seems to do so. Perhaps rename to
`shouldSaveToConfigXml`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
