Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/282#issuecomment-134217638
Looks good! and very clean.
One note about tests, jasmine spies seem to give you a lot of trouble. In
the previous refactoring round I was doing, I found it very useful to entirely
replace some tests that rely on spies too much with something based on
filesystem fixtures with less spying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
