Thanks, Joe for the summary of the impact later. -1. IMO - a naming change is no worth the effort and future breakage.
-Nikhil -----Original Message----- From: Joe Bowser [mailto:[email protected]] Sent: Wednesday, October 21, 2015 11:06 AM To: dev <[email protected]> Subject: Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface Yes, I do. I had to search through mobilespec, but here it is: private static final boolean HAS_BUILT_IN_SPLASH_SCREEN = Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4; Also, every plugin that calls initialize requires a CordovaWebView passed into it. That's a pretty big change. I also haven't touched on Third Party WebViews like Crosswalk, which would have to do the change. On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill <[email protected]> wrote: > Joe, do you have a small example of what could break with this change. > What is a usecase for someone to reference CordovaWebView > > On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser <[email protected]> wrote: > > > I'll pull this in at the end of the day. This small change may > > break > stuff > > further down the road, so people should comment on it now. > > > > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser <[email protected]> wrote: > > > > > OK, Going to pull this in. > > > > > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald < > > > [email protected]> wrote: > > > > > >> +1 from me as I'm the one that initiated the PR. > > >> > > >> Simon Mac Donald > > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fh > > >> i.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c8 > > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db4 > > >> 7%7c1&sdata=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d > > >> > > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue <[email protected]> > > wrote: > > >> > > >> > +1 for doing this with the major version bump > > >> > > > >> > On 20 October 2015 at 09:15, Joe Bowser <[email protected]> wrote: > > >> > > > >> > > Hey > > >> > > > > >> > > We're close to getting 5.0.x ready for release, but I want to > > >> > > add > > one > > >> > more > > >> > > pull request: > > >> > > > > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f227&data=0 > > >> > > 1%7c01%7cnikhilkh%40microsoft.com%7c8619031b1eef484bd48508d2d > > >> > > a425e41%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=w5TYcbCH > > >> > > %2fhLIhbrZImOsVFgGMfp%2bIk0Dl6Qk6ADzMVc%3d > > >> > > > > >> > > This is a trivial pull request, but I want to get buy-in from > > >> > > the > > list > > >> > for > > >> > > doing the rename for CordovaWebView class to be changed > > >> > > before we > > >> start > > >> > > deprecating it. This means we're probably going to remove > > >> > > the > shim > > in > > >> > the > > >> > > next major version. > > >> > > > > >> > > Thoughts? > > >> > > > > >> > > Joe > > >> > > > > >> > > > >> > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
