That's a pretty good point. When I was working on it, I figured that since this was a platform specific issue, mimicking the platform's API (Android's onSaveInstanceState) was the way to go. Expanding CoreAndroid's secret APIs is probably worth avoiding though.
Thanks, Richard -----Original Message----- From: Jesse [mailto:[email protected]] Sent: Wednesday, October 28, 2015 2:49 PM To: [email protected] Subject: Re: [GitHub] cordova-android pull request: API for saving/restoring plugin and ... This sounds really good! The only reservation I have is making a new non-standard way of saving state in js. Instead of providing navigator.app.saveState() I think we should be content to simply raise the event, and allow the app developer to choose how they wish to store it. The obvious choice would be simply dumping some data in localStorage. @purplecabbage https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c43887f38590b4cf68f2908d2dfe1b049%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=S4Sqckds4SE%2f%2fngCXBWQxZkvofnRUIUgn0x9J0krBO0%3d On Wed, Oct 28, 2015 at 1:52 PM, riknoll <[email protected]> wrote: > Github user riknoll commented on the pull request: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > b.com%2fapache%2fcordova-android%2fpull%2f236%23issuecomment-151986714 > &data=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c43887f38590b4cf68f2 > 908d2dfe1b049%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=pSCIkGF0LeL > 9R224b1tsyXH83iYwszeDAT1zxlpfQsQ%3d > > Here's an example index.js and index.html: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist. > github.com%2friknoll%2f94a40dc147040191fd3e&data=01%7c01%7cRIKNOLL%40e > xchange.microsoft.com%7c43887f38590b4cf68f2908d2dfe1b049%7c72f988bf86f > 141af91ab2d7cd011db47%7c1&sdata=5CXyfzbtGMcv%2fnicW7PZffrxnykSiOo4Jk5X > wLGKcIA%3d > > For anyone hoping to test it out, make sure you check "Don't keep > activities" in your phone's developer options. > > > --- > If your project is set up for it, you can reply to this email and have > your reply appear on GitHub as well. If your project does not have > this feature enabled and wishes so, or if the feature is enabled but > not working, please contact infrastructure at > [email protected] or file a JIRA ticket with INFRA. > --- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
