Github user dblotsky commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-file-transfer/pull/115#discussion_r46073628
  
    --- Diff: tests/tests.js ---
    @@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
                             expect(transfer.onprogress).toHaveBeenCalled();
     
                             // check that there is no file
    -                        root.getFile(localFilePath, null, 
unexpectedCallbacks.fileSystemWin, done);
    +                        root.getFile(fileName, null, 
unexpectedCallbacks.fileSystemWin, done);
    --- End diff --
    
    That sounds like a bug in `getFile`. The test code should obey what the 
docs say, and the implementation should be fixed, no? This sounds like an 
actual bug that the tests are uncovering.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to