+1 Confirmed sigs & hashes with `coho verify-archive` Verified hash matches tag with `coho verify-tags` Re-created archive with `coho create-archive`, verified contents match release candidate
Created app w/ `cordova platform add https://github.com/apache/cordova-ios#4.0.1` Ran on device and simulator w/ `cordova run ios--device` and `cordova run ios` On 12/17/15, 8:31 AM, "Carlos Santana" <[email protected]> wrote: >I vote +1 > >Review code changes in commits >Use coho verify-tags >Use coho create-archive and compare contents >Created app using uiwenview >Created app using wkwebview >Correct version 4.0.1 is reported using CLI and Runtime > > >On Wed, Dec 16, 2015 at 5:48 PM Shazron <[email protected]> wrote: > >> Please review and vote on this 4.0.1 iOS Release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> Release issue: https://issues.apache.org/jira/browse/CB-10203 >> >> The archive has been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/CB-10203 >> >> The package was published from its corresponding git tag: >> cordova-ios: 4.0.1 (7890eae664) >> >> Note that you can test it out via: >> >> cordova platform add https://github.com/apache/cordova-ios#4.0.1 >> >> (you might have to use the Apache git servers) >> >> Upon a successful vote I will upload the archive to dist/, publish it >> to npm, and post the blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and >> subdependencies have Apache-compatible licenses >> * Ensured continuous build was green when repo was tagged (tested file >> transfer on my own server) >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
