Hey Sean, We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those.
According to ASF policies, only PMC members can vote. I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it reviewed and in the next inappbrowser plugin release. We can do another inappbrowser release shortly after. Cheers, -Steve On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly <[email protected]> wrote: > I'd vote no. I'd really like to see CB-7786 get in before the next release. > > SeanK > > On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < > [email protected]> wrote: > > > Please review and vote on the InAppBrowser plugin release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-10505 > > > > The plugin has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-10505/ > > > > The package were published from their corresponding git tag: > > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) > > > > Upon a successful vote I will upload the archives to dist/, upload them > to > > the Plugins Registry, and post the corresponding blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Run auto tests for iOS, Android and Windows > > > > -Sergey > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
