Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/386#discussion_r52726089
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible 
(platformOptions) {
         }).map(function (arg) {
             return opts[arg] === true ?
                 '--' + arg :
    -            '--' + arg + '="' + opts[arg].toString() + '"';
    +            '--' + arg + '=' + opts[arg].toString();
    --- End diff --
    
    Why are we passing string CLI arguments in a programmatic API? If this is 
because we're using `cordova.raw`, then can we refactor to not use it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to