GitHub user TanaseButcaru opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/170

    Fix FileHelper / port cordova-plugin-filepath-unofficial and replace 
getRealPath with it

    I recently encountered the ``FileNotFoundException ouputModifiedBitmap`` 
error while using this plugin and I've tried all PRs available here but none 
seems to fix the issue.
    The current implementation of FileHelper does not deal well with files from 
external (and even internal) SD card (removable or not).
    I also had issues getting videos file paths.
    
    I was using 
[cordova-plugin-filepath](https://github.com/TanaseButcaru/cordova-plugin-filepath-unofficial)
 to get the ``file://`` path from a ``content://`` one. 
    This plugin had its one issues, which I managed to fix & improve it as a 
whole. 
    
    Because the filepath plugin is doing its job well, I ported it to the 
cordova-plugin-camera. This looks a lot like PR #93 , just that it is updated.
    The only case where this fails (as far as I have tested) is the case when 
user selects a picture/video from Google Drive (there's no solution for this in 
#143 PR too).
    
    This closes the following:
    * #160 
    * #155 
    * #149
    * #148 
    * #143 
    * #135 
    * #112 
    * #93  
    
    You can test this PR & the #169 PR from my [unofficial version 
release](https://github.com/TanaseButcaru/cordova-plugin-camera-unofficial) of 
cordova-plugin-camera.

You can merge this pull request into a Git repository by running:

    $ git pull 
https://github.com/TanaseButcaru/cordova-plugin-camera-unofficial 
port-filepath-unofficial

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #170
    
----
commit 72c2f1332f27d2b8f115814de8a978fa8472c0b8
Author: TanaseButcaru <[email protected]>
Date:   2016-02-15T01:20:06Z

    port cordova-plugin-filepath-unofficial and replace getRealPath with it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to