Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/260#discussion_r53140038
  
    --- Diff: bin/templates/cordova/lib/run.js ---
    @@ -41,8 +41,9 @@ var path  = require('path'),
     
         var self = this;
     
    -    var install_target = runOptions.device ? '--device' :
    -        runOptions.emulator ? '--emulator' :
    +    var install_target = !runOptions.target ?
    --- End diff --
    
    IMO this statement looks very complex - there is 3 ternary operators in one 
expression. Could you please try to simplify this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to