Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029617
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
var PlatformMunger =
require('cordova-common').ConfigChanges.PlatformMunger;
var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
-var ConsoleLogger = require('./lib/ConsoleLogger');
var pluginHandlers = require('./lib/pluginHandlers');
+var CordovaLogger = require('cordova-common').CordovaLogger;
+var selfEvents = require('cordova-common').events;
var PLATFORM = 'android';
+function setupEvents(externalEventEmitter) {
--- End diff --
Could you make this function return the emitter instance?
`setupEvents(events); events = events || selfEvents;` -> `events =
setupEvents(events);`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
