GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/135
Removing the expectation in spec.34 for the transfer method to be called
The expectation in this spec is causing the crash in the build process. The
error message is "Expected Spy but got a function". This error will happen only
if there is no spy on the function. But as you can see the spy is set and still
we get the error.
In order to avoid the error, I am commenting out this expectation. I do not
think this would have any adverse impact as we do check for the error code (to
be aborted) and the presence of the file(the purpose of this spec). So, I am
confident that we are not losing any functionality by commenting out this
expectation.
@rakatyal @riknoll @omefire Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-plugin-file-transfer
CB-10409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 37d3d2eeb9228638826681e717027ed2dbf57630
Author: Sarangan Rajamanickam <[email protected]>
Date: 2016-03-30T19:39:09Z
Removing the expectation in spec.34 for the transfer method to be called.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
