Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59037903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
if (missingVariables.length) {
shell.rm('-rf', pluginInfo.dir);
+ events.emit('verbose', 'Removing ' +
pluginInfo.dir + ' due to installation failure');
var msg = 'Variable(s) missing (use:
--variable ' + missingVariables.join('=value --variable ') + '=value).';
--- End diff --
> plugin isn't getting removed since it hasn't been installed
Right, but the previous message in console states something like 'Copying
plugin ../source/path => plugin/destination path' (see
[fetch.js#L352](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L352))
so we just crarifying that we've copied the folder but now removing it due to
restore failure
> replacing it by events.emit(msg), with msg defined at L161
This is already emitted at
[restore-util#R127](https://github.com/apache/cordova-lib/pull/420/files#diff-e9221ac2a69074d78c7fb9a8e6b9d4d6R127),
why we need to duplicate that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
