Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853
Thank you, my pleasure.
I have thought about this a bit longer.. The main issue is that recent
Cordova changes, namely introducing WKWebView, have broken this plugin for a
significant use case, namely OAuth. The changes suggested here put the
functionality back to how it was before the internal changes broke it. I'd
prefer a different solution but until we have that I think it's important that
the plugin does what it's supposed to.
Making these changes depend on an option like `modal: false` is a bit like
providing the option `worksAsItIsSupposedTo: true`. If anything we could
provide an option `useStrictlyModalBrowser: true` or similar to opt-in to the
new WKWebView behaviour.
@jcesarsh what do you think, looking at this in that light?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
