Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61621269
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (success, fail, service, action, args) {
+ // Handle the case when we have an old version of splashscreen plugin
to avoid the API calls failures
+ if (service === 'SplashScreen') {
+ var pluginsVersions = require("cordova/plugin_list").metadata;
+ var splashscreenVersion =
pluginsVersions['cordova-plugin-splashscreen'];
+ var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+ if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) <
MIN_SPLASHSCREEN_SUPPORTED_VER) {
+ console.log('Warning: cordova-plugin-splashscreen has been
hooked into for compatibility reasons. Update the plugin to version >= 4.');
--- End diff --
Consider updating the message to something like: "A more recent version of
cordova-plugin-splashscreen has been hooked into..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
