GitHub user jakub-g opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/167
doc: do not use `with` in JS samples
The usage of `with` JS statement is highly discouraged for a number of
reasons, see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with
http://www.2ality.com/2011/06/with-statement.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jakub-g/cordova-plugin-inappbrowser patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit f42226dddb1b05cdbbf094185dfcd2658ec7254b
Author: jakub-g <[email protected]>
Date: 2016-05-18T13:55:27Z
doc: do not use `with` in JS samples
The usage of `with` JS statement is highly discouraged for a number of
reasons, see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with
http://www.2ality.com/2011/06/with-statement.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
