GitHub user philbenoit opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/130
CB-11532: (ios) Fix bug with bad characters in contact name
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fixes https://issues.apache.org/jira/browse/CB-11532
### What testing has been done on this change?
Testing on the problem device iOS 9.3 - iPhone 5s.
### Checklist
- [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed
and submitted to [email protected].
- [ Yes ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug
with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the
platform affected.
- [ No ] Added automated test coverage as appropriate for this change.
This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit
heavy to create new dictionaries for each user.
Please also look to add code tests as I have no knowledge of this, the
names causing issues are listed below.
I have tested this in the wild with a phone containing the contacts below
and it has solved the issue.
Gökmen
Brûlé
França
çïÃËçñï
Gabby ââ¬Â¢Ã¢â¬Â¢Ã¢â¬Â¢Ã¢â¬Â¢
Damián M.A.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/philbenoit/cordova-plugin-contacts patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 430770c51fc4377db1f8ef3f4e251c6189fcd29f
Author: KiwiDC <[email protected]>
Date: 2016-07-04T09:33:49Z
Update CDVContacts.m
This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit
heavy to create new dictionaries for each user.
I have tested this in the wild with a phone containing the contacts below
and it has solved the issue.
Gökmen
Brûlé
França
çïÃËçñï
Gabby ââ¬Â¢Ã¢â¬Â¢Ã¢â¬Â¢Ã¢â¬Â¢
Damián M.A.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
