GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/470
CB-11636 Handle attributes with quotes correctly
This PR changes `mergeXml` inner implementation to avoid using
`elementtree.findall()` with complex queries such as
`tag[@attrib1="value1"][@attrib2="value2"]` to avoid issues with attributes w/
double quotes inside. Instead we use `findall('tag')` and the filter out
unwanted candidates
For more details see
[CB-11636](https://issues.apache.org/jira/browse/CB-11636) and
[CB-11613](https://issues.apache.org/jira/browse/CB-11613)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-11636
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #470
----
commit e0f556333040594ddca7920100a1e6b64da866cc
Author: Vladimir Kotikov <[email protected]>
Date: 2016-07-28T09:44:59Z
CB-11636 Handle attributes with quotes correctly
Avoid using complex queries in et.findall to prevent
issues w/ quoted values. Previous approach w/ crafting
complex query from attributes names and values was faulty
when any of the attributes had double quotes or "
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
