GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/107
CB-11655 (Android) Enabled asynchronous error handling
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Fixes a crash and enables asynchronous MediaPlayer error handling.
The crash was happening because the plugin wasn't catching the error from
Android's MediaPlayer and thus when the error (in this case,
[MEDIA_ERROR_TIMED_OUT](https://developer.android.com/reference/android/media/MediaPlayer.html#MEDIA_ERROR_TIMED_OUT))
occurred, the plugin wasn't aware of this and tried to send new commands to
the MediaPlayer which was causing the crash.
### What testing has been done on this change?
Manual and automatic mobilespec tests on Android 4.4 emulator.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-media CB-11655
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 6557e2478702fed410f0c28c4814aeb4ae45f534
Author: Alexander Sorokin <[email protected]>
Date: 2016-08-12T15:37:23Z
CB-11655 (Android) Enabled asynchronous error handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
