GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/116
CB-1187: (iOS) Fix unused recording settings
### Platforms affected
iOS
### What does this PR do?
easy fix: audioSettings object wasn't being passed in when starting a
recording.
### What testing has been done on this change?
run automated tests, run in custom app. All works as expected.
build in xcode. Cleared up 2 warnings for an unused variable and null
argument passed to recorder.
### Checklist
- [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [ X] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghenry22/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 642aef774aa60a34b29d451f684ffc67bf732700
Author: ghenry22 <[email protected]>
Date: 2016-09-07T01:37:59Z
CB-1187: (iOS) Fix unused recording settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
