GitHub user kenichi-fukushima opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/49
CB-11838 ios: Unregister callback function at the right timing.
### Platforms affected
iOS
### What does this PR do?
Make it so the CDVReachability object unregisters a callback function at
the right timing.
### What testing has been done on this change?
No automated test. I couldn't reproduce an issue that this patch fixes.
However, it suppressed a 40K daily crash reports at LINE.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [N/A] Added automated test coverage as appropriate for this change.
We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/kenichi-fukushima/cordova-plugin-network-information
reachability-callback
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 22a835ceac3339f6b5e595d7733f273c01aa0538
Author: Ken'ichi Fukushima <[email protected]>
Date: 2016-09-12T09:28:49Z
CB-11838 ios: Unregister callback function at the right timing.
We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
