GitHub user manucorporat opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
CB-11136: InAppBrowser fails to close with WKWebView OAuth
### Platforms affected
iOS (device only)
### What does this PR do?
Avoids presenting the InAppBrowser directly over the UIViewController used
by WKWebView which causes the WKWebView thread to block.
Since the WKWebView thread is blocked it can not receive the some important
events like 'loadend', preventing the use of OAuth.
### What testing has been done on this change?
Testing in Simulator iOS9.3, Simulator iOS10, Device iOS10
### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manucorporat/cordova-plugin-inappbrowser
master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit ce33cf5ac733854bba8d1b578c2ca58ff23b237b
Author: Manu Mtz.-Almeida <[email protected]>
Date: 2016-09-19T20:51:08Z
CB-11136: InAppBrowser fails to close with WKWebView OAuth
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
