I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core plugins * Verified release notes * Verified version * Verified line breaks
-- Alexander Sorokin -----Original Message----- From: Jesse [mailto:[email protected]] Sent: Tuesday, October 25, 2016 3:17 AM To: [email protected] Subject: Re: [Vote] 4.4.3 Windows Release I vote +1 * Ran coho verify-archive * Ran coho audit-license-headers * Ran coho check-license * Ensured continuous build was green when repo was tagged * ran npm install && npm run cover * created a test app, added platform and ran it successfully @purplecabbage risingj.com On Mon, Oct 24, 2016 at 2:04 PM, Shazron <[email protected]> wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * ran npm install && npm run cover > > On Mon, Oct 24, 2016 at 8:49 AM, Sergey Shakhnazarov (Akvelon) < > [email protected]> wrote: > > > Please review and vote on this 4.4.3 Windows Release by replying to > > this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss > > ues.apache.org%2Fjira%2Fbrowse%2FCB-12031&data=02%7C01%7Cv-alsoro%40 > > microsoft.com%7Cc7aca0301e4749d06b2b08d3fc6c3604%7C72f988bf86f141af9 > > 1ab2d7cd011db47%7C1%7C0%7C636129514127649863&sdata=K21Jf2KGioKKbMrBW > > LmBo3lhQEqROiMJ%2BCTNoV0ABP0%3D&reserved=0 > > > > The archive has been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdis > > t.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12031&data=02%7C01% > > 7Cv-alsoro%40microsoft.com%7Cc7aca0301e4749d06b2b08d3fc6c3604%7C72f9 > > 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C636129514127649863&sdata=1yH3 > > caL6h%2Bc2tVqQLs5qZei7%2BgaeeNbPHU%2FRgwF70r4%3D&reserved=0 > > > > The package was published from its corresponding git tag: > > cordova-windows: 4.4.3 (1299ade53c) > > > > Note that you can test it out via: > > > > cordova platform add > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > > hub.com%2Fapache%2Fcordova-windows%234.4.3&data=02%7C01%7Cv-alsoro%4 > > 0microsoft.com%7Cc7aca0301e4749d06b2b08d3fc6c3604%7C72f988bf86f141af > > 91ab2d7cd011db47%7C1%7C0%7C636129514127649863&sdata=o%2FBR48VDunnmQh > > %2BT%2FY4XVIoaU5JbayqZ7GjxI5pIe3Q%3D&reserved=0 > > > > Upon a successful vote I will upload the archive to dist/, publish > > it to npm, and post the blog post. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > > hub.com%2Fapache%2F&data=02%7C01%7Cv-alsoro%40microsoft.com%7Cc7aca0 > > 301e4749d06b2b08d3fc6c3604%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C > > 0%7C636129514127649863&sdata=jlChTnKPwJsiuj1Y%2FNsF6EbCWJCP9FRyYOdPB > > OakFL0%3D&reserved=0 cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > > > * Ensured that all tests pass > > > > * Created, built and ran mobilespec app > > > > * Tested create and update scenarios via platform scripts and > > cordova-cli > > > > Please let me know if you have any questions or considerations. > > > > Best regards, > > Sergey Shakhnazarov. > > > > > > >
