Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752512
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+ 'windows': {
+ '8.1.0': 'package.windows.appxmanifest',
+ '10.0.0': 'package.windows10.appxmanifest'
+ },
+ 'phone': {
+ '8.1.0': 'package.phone.appxmanifest',
+ '10.0.0': 'package.windows10.appxmanifest'
+ },
+ 'all': {
+ '8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+ '10.0.0': 'package.windows10.appxmanifest'
+ }
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+ CommonPluginInfo.apply(this, arguments);
+ var parentGetConfigFiles = this.getConfigFiles;
+ this.getConfigFiles = function(platform) {
+ var changes = parentGetConfigFiles(platform);
+ var editChanges = this.getEditConfigs(platform);
+ if (editChanges && editChanges.length !== 0) {
+ changes.push(editChanges);
+ }
+ // Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+ // Only spend the cycles if there are version-specific plugin
settings
+ if (changes.some(function(change) {
+ return change.target === 'package.appxmanifest';
+ }))
+ {
+ var oldChanges = changes;
+ changes = [];
+
+ oldChanges.forEach(function(change, changeIndex) {
+ // Only support semver/device-target demux for
package.appxmanifest
+ // Pass through in case something downstream wants to use
it
+ if (change.target !== 'package.appxmanifest') {
+ changes.push(change);
+ return;
+ }
+
+ var hasVersion = (typeof change.versions !== 'undefined');
+ var hasTargets = (typeof change.deviceTarget !==
'undefined');
+
+ // No semver/device-target for this config-file, pass it
through
+ if (!(hasVersion || hasTargets)) {
+ // New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+ var substs = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+ changes = changes.concat(substs.map(function(subst) {
+ return Object.assign({}, change, {target: subst});
+ }));
+ return changes;
--- End diff --
Nit: you can just `return` here - result of this function is not used
anywhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
