GitHub user romedius opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/121
CB-12146: (android) Adds support for "playAudioWhenScreenIsLocked" already
used in iOS
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Handle sound pausing and resuming on events like onPause, AudioFocus and if
the phone rings.
In this patch we handle the playAudioWhenScreenIsLocked option and we must
handle three cases independently
* on Pause and onResume - pause depening if playAudioWhenScreenIsLocked is
set for this audio player
* AudioFocus (refactored)
* phone ringing (refactored)
We have three general states:
* No paused sounds
* All sounds paused
* Sounds only paused if the playAudioWhenScreenIsLocked flag is set to
false
### What testing has been done on this change?
Manual testing on Nexus 5
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romedius/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 941062bcbe6bc9631fa47a16f73e06e5b9390460
Author: Romedius Weiss <[email protected]>
Date: 2016-11-14T15:03:11Z
added playAudioWhenScreenIsLocked support
commit f5e802afc24b07f88b60246106455ed6f8c31301
Author: Romedius Weiss <[email protected]>
Date: 2016-11-14T20:32:13Z
Handle sound pausing and resuming on events like onPause, AudioFocus and if
the phone rings.
In this patch we handle the playAudioWhenScreenIsLocked option and we must
handle three cases independently
* on Pause and onResume - pause depening if playAudioWhenScreenIsLocked is
set for this audio player
* AudioFocus (refactored)
* phone ringing (refactored)
We have three general states:
* No paused sounds
* All sounds paused
* Sounds only paused if the playAudioWhenScreenIsLocked flag is set to
false
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
