I vote +1 I ran the following tests against an iOS 10.1 iPhone 7 plus simulator
1. mobilespec autotests - i get the two media failures that seem to be expected (at least per Kerri’s vote) - i get file.spec.147 failure every time w/ code:1 NOT_FOUND_ERR. manual file tests all pass fine, though. - i get two file transfer failures, either spec.42 or spec.44 (they seem to alternate?), plus spec.45, when using evening-reaches-13417.herokuapp.com as the remote FT server manual tests - all worked (at least the ones that are simulator-compatible) except: - file-transfer: video download via cdvfile shows a broken play button and unplayable video. via native works fine. - media: on step 7 of the recommended test procedures (pressing play after pressing release), track does not start playing and log shows an Audio Error: 4. System Log does not glean anything more. 2. ./bin/create + ./cordova/build + ./cordova/run works fine On Thu, Dec 1, 2016 at 10:32 AM, Kerri Shotts <[email protected]> wrote: > I vote +1: > > Created mobilespec for ios > Ran mobilespec auto tests on iOS emulator, some failures (all expected on my end: file-transfer & 2 media tests) > Ran npm test, no errors > Created hello-world app via CLI, OK > Ran on device OK > Upgraded app via CLI, OK > Ran cordova-lib tests, no errors > Tested storyboard launch images, OK > Ran on device, OK > > ~ Kerri > >> On Nov 30, 2016, at 19:28, Shazron <[email protected]> wrote: >> >> Please review and vote on this 4.3.1 iOS Release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> Release issue: https://issues.apache.org/jira/browse/CB-12203 >> >> The archive has been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/CB-12203 >> >> The package was published from its corresponding git tag: >> cordova-ios: 4.3.1 (8fe24d41b0) >> >> Note that you can test it out via: >> >> cordova platform add https://github.com/apache/cordova-ios#4.3.1 >> >> Upon a successful vote I will upload the archive to dist/, publish it to >> npm, and post the blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and sub-dependencies >> have Apache-compatible licenses >> * Ensured continuous build was green when repo was tagged >
