GitHub user joeljeske opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/29
CB-12414: (iOS) Forward error from provisional load error to standardâ¦
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
It listens for `didFailProvisionalNavigation` errors on the
WKNavigationDelegate and handles them as standard load errors.
`- (void)webView:(WKWebView *)webView
didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError
*)error`
This allows the error page to be shown for all load errors, instead of just
some.
Description
See ticket CB-12414
### What testing has been done on this change?
Manual repro steps as seen in CB-12414 to see that it is fixed.
### Checklist
- [x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joeljeske/cordova-plugin-wkwebview-engine
bug/support-provisional-load-failure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 74045882d6f0aa4aaef93326c903be9d7e65f187
Author: Joel Jeske <[email protected]>
Date: 2017-02-01T17:48:13Z
CB-12414: (iOS) Forward error from provisional load error to standard load
error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
