I vote +1. * Ran coho verify-archive * Verified tag * Verified version * Ability to create blank app for Windows, Android * Ability to build/run apps * Reviewed release notes * Verified 'cordova serve' * Verified that browserified app builds and runs correctly
-----Original Message----- From: Steven Gill [mailto:[email protected]] Sent: Friday, March 10, 2017 1:09 AM To: [email protected] Subject: Re: [VOTE] cordova-common 2.0.1 Release +1 * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran `npm test` in both `master` and `common-2.0.x` branches, for both before-and-after the changes. In all four cases, tests passed. On Thu, Mar 9, 2017 at 12:49 PM, Filip Maj <[email protected]> wrote: > Please review and vote on this cordova-common release by replying to > this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-12558 > > cordova-common 2.0.1 has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-12558 > > The packages were published from their corresponding git tags: > > ~/src via ⬢ v6.9.4 > ➔ coho print-tags -r common > Running from /Users/maj/src > cordova-lib: common-2.0.1 (3d6311f464) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm. I made a call that this was a small enough release that a > blog post is not warranted. Feel free to respond if you disagree, and > I can put that together. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran `npm test` in both `master` and `common-2.0.x` branches, for > both before-and-after the changes. In all four cases, tests passed. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
