GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-docs/pull/688

    Remove misleading reference to "publisherId" cause it is ignored

    The only way to override the `Publisher` value in the generated 
`AppxManifest.xml` is to provide a custom signing certificate. Merely setting 
the "publisherId" does not do anything. I've tried it a whole day. Only when I 
set a custom signing certificate my applications manifest looked like it 
should. And then setting "publisherId" to anything did not affect how the 
resulting manifest file looked.
    So I propose to remove the value from the docs (and it should also be 
removed from the Cordova Windows plugin).
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pke/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #688
    
----
commit 62b148bb62714676aff0c02b7bd719a6746a7e24
Author: Philipp Kursawe <[email protected]>
Date:   2015-10-23T21:45:51Z

    Remove misleading reference to "publisherId" cause it is ignored
    
    The only way to override the `Publisher` value in the generated 
`AppxManifest.xml` is to provide a custom signing certificate. Merely setting 
the "publisherId" does not do anything. I've tried it a whole day. Only when I 
set a custom signing certificate my applications manifest looked like it 
should. And then setting "publisherId" to anything did not affect how the 
resulting manifest file looked.
    So I propose to remove the value from the docs (and it should also be 
removed from the Cordova Windows plugin).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to