GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-lib/pull/547
CB-8978: Add option to get resource-file from root
Step 1 of resolving the first issue mentioned in
https://github.com/apache/cordova-android/pull/321#issuecomment-294985346
Step 2 will be updating the `cleanFileResources` function to pass in the
new option.
This is needed for cleaning the resource-file targets, since they are at
the top level of the platform's config.xml.
/cc @shazron
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS, Android
### What does this PR do?
Provides an option to return `resource-file` tags from the top level of
config.xml, instead of only returning ones nested under a particular platform.
### What testing has been done on this change?
Added spec test to verify top-level resource-files are returned when the
option is specified.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-lib resource-file-clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #547
----
commit 8a4dde1efa12d9bfc6f409ff6360e67e3a53b13f
Author: Darryl Pogue <[email protected]>
Date: 2017-04-21T06:45:12Z
CB-8978: Add option to get resource-file from root
This will be needed for cleaning the resource-file targets, since they
are at the top level of the platform's config.xml.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
