Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/552#discussion_r114960540
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -205,8 +205,29 @@ module.exports = function plugin(command, targets,
opts) {
.thenResolve(pluginInfo);
})
.then(function(pluginInfo){
+ var pkgJson;
+ var pkgJsonPath =
path.join(projectRoot,'package.json');
+
// save to config.xml
if(saveToConfigXmlOn(config_json, opts)){
+ // If statement to see if pkgJsonPath
exists in the filesystem
+ if(fs.existsSync(pkgJsonPath)) {
+ // Delete any previous caches of
require(package.json)
+ pkgJson =
cordova_util.requireNoCache(pkgJsonPath);
+ }
+ // If package.json exists, the plugin
object and plugin name
+ // will be added to package.json if not
already there.
+ if(pkgJson){
--- End diff --
nitpick: can you add a space before the {.
`if(pkgJson) {`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
