Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123834356
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath,
target_api) {
fs.writeFileSync(dstPath, data);
}
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build
system?
--- End diff --
Would folding this functionality up into the Builder abstraction make sense
here? Would different project structures require different building different
things at create time as well? Put otherwise: do the Builders have to do
specific things at create-time as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
