GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/397
CB-13031: Fix bug with case-sensitivity of android-packageName
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
self
### What does this PR do?
Steps to reproduce:
1) cordova create testapp com.example.testapp testapp
2) cd testapp
3) edit config.xml, add android-packageName="com.example.Testapp" to
<widget>
4) cordova platform add android
Since `windows` and `osx` file systems are case-insensitive, [this
line](https://github.com/apache/cordova-android/blob/893356abcd1b005a13bb09e7467f227b52de3ae5/bin/templates/cordova/lib/prepare.js#L213)
doesn't create a directory with a name from `android-packageName` attribute if
it differs in casing from original package name.
This PR makes case-sensitive check before removal of an old package.
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-android CB-13031
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit 61add83c4145a234df0c9cfd5bdbfdd4dd945609
Author: Nikita Matrosov <[email protected]>
Date: 2017-07-19T13:36:20Z
CB-13031: Fix bug with case-sensitivity of android-packageName
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
