I vote +1: * Ran coho audit-license-headers * Ran coho check-license * Ran mobilespec * Created hello-world app, deployed to emulator * Npm test
On 10/9/17, 2:31 PM, "Suraj Pindoria" <[email protected]> wrote: >Please review and vote on this 4.5.2 iOS Release >by replying to this email (and keep discussion on the DISCUSS thread) > >Release issue: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-13417&data=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281&sdata=BMubFWb0jXgG4YLJ0s1PsbA41%2BE1Otg4czucF9dJ5Cw%3D&reserved=0 > >The archive has been published to dist/dev: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-13417&data=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281&sdata=YIbWlOxnUTuAdZP477MSp5RwhYU2T%2BH%2BA8XVHnPmql0%3D&reserved=0 > >The package was published from its corresponding git tag: >PASTE OUTPUT OF: coho print-tags -r ios --tag 4.5.2 > >Note that you can test it out via: > > cordova platform add > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-ios%234.5.2&data=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281&sdata=%2BvRhaYsrhnwG4MJHfg6xoNDErQtKd8mfaU4rR9EqX0M%3D&reserved=0 > >Upon a successful vote I will upload the archive to dist/, publish it to >npm, and post the blog post. > >Voting guidelines: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281&sdata=NFxGZlIHyzj67518JJhXiDRxQowV%2FTO6O9RZSBOs7mg%3D&reserved=0 > >Voting will go on for a minimum of 48 hours. > >I vote +1: >* Ran coho audit-license-headers over the relevant repos >* Ran coho check-license to ensure all dependencies and subdependencies >have Apache-compatible licenses >* Ensured continuous build was green when repo was tagged >* Ran mobilespec >* Created hello-world, deployed to emulator/device >* Checked create/build/version scripts
