I vote +1 * Ran coho verify-archive * Ran coho audit-license-headers * Ran coho check-license * ran npm test * made sure blank app creates and builds
@purplecabbage risingj.com On Thu, Feb 22, 2018 at 12:43 AM, <[email protected]> wrote: > I vote +1. > > * Verified archives via `coho verify-archive` > * Verified tag manually > * Verified that blank app creates correctly with platform > * Verified that blank app can be successfully built and ran > * Verified that platform can be updated from previous version > * Verified release notes > * Verified version > * Verified whitespace and Unicode compatibility > * Verified App Cert Kit compatibility > > -- Alexander Sorokin > > -----Original Message----- > From: Steven Gill <[email protected]> > Sent: Thursday, February 22, 2018 12:53 AM > To: [email protected] > Subject: Re: [VOTE] [email protected] Release > > I vote +1 > > * Ran coho verify-archive > * Ran coho audit-license-headers > * Ran coho check-license > * ran npm test > > On Tue, Feb 20, 2018 at 2:51 PM, Jan Piotrowski <[email protected]> > wrote: > > > Please review and vote on this 6.0.0 Windows Release by replying to > > this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue > > s.apache.org%2Fjira%2Fbrowse%2FCB-13896&data=04%7C01%7Cv-alsoro%40micr > > osoft.com%7Ccf68af32075a4250923508d5797582d1%7C72f988bf86f141af91ab2d7 > > cd011db47%7C1%7C0%7C636548467964989739%7CUnknown%7CTWFpbGZsb3d8eyJWIjo > > iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=yZE2V > > A%2FjZzXy1pr8kIFxk6BF8qt47L5bTKZwSKAn0bQ%3D&reserved=0 > > > > The archive has been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist. > > apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-13896&data=04%7C01%7Cv- > > alsoro%40microsoft.com%7Ccf68af32075a4250923508d5797582d1%7C72f988bf86 > > f141af91ab2d7cd011db47%7C1%7C0%7C636548467964989739%7CUnknown%7CTWFpbG > > Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C- > > 1&sdata=P%2FvWPbAIsu98SS30Bh3GqhwYovVr9k9G4ZXtnaKBItY%3D&reserved=0 > > > > The package was published from its corresponding git tag: > > cordova-windows: 6.0.0 (c40fedff1a) > > > > Note that you can test it out via: > > > > cordova platform add > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > > b.com%2Fapache%2Fcordova-windows%236.0.0&data=04%7C01%7Cv-alsoro%40mic > > rosoft.com%7Ccf68af32075a4250923508d5797582d1%7C72f988bf86f141af91ab2d > > 7cd011db47%7C1%7C0%7C636548467964989739%7CUnknown%7CTWFpbGZsb3d8eyJWIj > > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=xcWS > > zNTvMxOKYgSK74VTAetloqSku7Fwx1gDrhAqA7I%3D&reserved=0 > > > > Upon a successful vote I will upload the archive to dist/, publish it > > to npm, and post the blog post. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting. > > md&data=04%7C01%7Cv-alsoro%40microsoft.com%7Ccf68af32075a4250923508d57 > > 97582d1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63654846796498973 > > 9%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > > Ik1haWwifQ%3D%3D%7C-1&sdata=tOzos3t1Ys2s5CJvafWpXz7PQmLHhsg61qzFh7qNEM > > o%3D&reserved=0 > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * Ran npm test in cordova-windows > > * Ran mobile-spec tests and observed numerous (but expected) failures > > * Created, built and ran a project with the /bin scripts > > * Created, built and ran a project / hello world app using the CLI > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
