I also vote +1. I was also able to perform successfully the platform add, build, and run. Able to launch successfully the built app. Additionally, reviewed code changes in the osx repo regarding the patch release.
> On Aug 13, 2018, at 16:55, Shazron <[email protected]> wrote: > > I vote +1 > - I could add the platform > - I could run 'cordova build' and 'cordova run' successfully > > On Mon, Jul 30, 2018 at 12:26 PM Chris Brody <[email protected]> wrote: >> >> Please review and vote on this 4.0.2 cordova-osx (macOS) patch release >> by replying to this email (and keep discussion on the DISCUSS thread). >> >> Release issue: https://issues.apache.org/jira/browse/CB-14228 >> >> The archive has been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/CB-14228/ >> >> The package was published from its corresponding git tag: >> >> cordova-osx: 4.0.2 (8cda5fa8d8) >> >> Note that you can test it out via: >> >> cordova platform add https://github.com/apache/cordova-osx#4.0.2 >> >> Upon a successful vote I will upload the archive to dist/, publish it >> to npm, and post the blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and >> subdependencies have Apache-compatible licenses >> * Ensured continuous build was green when repo was tagged >> * tested with cordova-sqlite-storage plugin using [email protected] >> (packaged with [email protected]) - more details in: >> https://github.com/apache/cordova-osx/pull/51 >> * additional testing with details in: >> https://github.com/apache/cordova-osx/pull/50 >> >> Proposed blog post in: https://github.com/apache/cordova-docs/pull/856 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
