I vote +1 - ran coho verify-archive on release artifacts - checked out the branch and ran `npm test` - continuous build was green when repo was tagged - created a project with latest released cordova tooling, added cordova-windows#6.0.1, ran on desktop and phone
``` npm i -g cordova cordova create ~/cb14226 cordova platform add https://github.com/apache/cordova-windows#6.0.1 ``` On Sun, Sep 16, 2018 at 2:33 PM Chris Brody <[email protected]> wrote: > Is there any way we can get a couple review votes on this patch > release that I made in August? > On Wed, Aug 1, 2018 at 2:56 AM Chris Brody <[email protected]> wrote: > > > > Can I get a couple reviews on this one, [email protected], and > > [email protected] in their respective [VOTE] threads? > > > > On Sun, Jul 29, 2018 at 10:56 PM Chris Brody <[email protected]> > wrote: > > > > > > Please review and vote on this 6.0.1 Windows patch release by replying > > > to this email (and keep discussion on the DISCUSS thread). > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-14226 > > > > > > The archive has been published to dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/CB-14226/ > > > > > > The package was published from its corresponding git tag: > > > > > > cordova-windows: 6.0.1 (cc4733ef64) > > > > > > Note that you can test it out via: > > > > > > cordova platform add > https://github.com/apache/cordova-windows#6.0.1 > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > > > to npm, and post the blog post. > > > > > > Voting guidelines: > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repo was tagged > > > * tested with cordova-sqlite-storage plugin using [email protected] > > > (packaged with [email protected]) and [email protected] (packaged with [email protected]) - > > > more details in: https://github.com/apache/cordova-windows/pull/287 > > > > > > Proposed blog post in: https://github.com/apache/cordova-docs/pull/854 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
