[
https://issues.apache.org/jira/browse/COUCHDB-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955670#comment-13955670
]
ASF GitHub Bot commented on COUCHDB-2215:
-----------------------------------------
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/201#discussion_r11135187
--- Diff: src/fauxton/app/addons/fauxton/base.js ---
@@ -202,21 +202,17 @@ function(app, FauxtonAPI, resizeColumns) {
afterRender: function(){
$('#primary-navbar li[data-nav-name="' + app.selectedHeader +
'"]').addClass('active');
- var menuOpen = true;
var $selectorList = $('body');
- $('.brand').off();
- $('.brand').on({
+ this.$('.burger').off();
+ this.$('.burger').on({
--- End diff --
Can you move the on Click to a backbone view event?
like this:
events: {
"click .brand":"toggleMenu"
},
then make toggleMenu part of the view object, instead of inside the
afterRender function.
> Update Primary Nav bar to match new docs
> ----------------------------------------
>
> Key: COUCHDB-2215
> URL: https://issues.apache.org/jira/browse/COUCHDB-2215
> Project: CouchDB
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Reporter: Sue Lockwood
>
> Update the animation. Add the burger to the top, Logo at the bottom, don't
> seperate the 2 menus.
--
This message was sent by Atlassian JIRA
(v6.2#6252)